Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails when multiple srcset values are present, and the first is remote #850

Closed
paulroub opened this issue Feb 14, 2025 · 1 comment
Closed

Comments

@paulroub
Copy link
Contributor

paulroub commented Feb 14, 2025

Input HTML:

<source srcset="https://example.com/big.png 2x, https://example.com/small.png 1x" type="image/png" />

We're checking for "is the url remote?" before the check for "are there multiple srcsets?"

We then treat the whole string as one big remote, and get failures like:

Received a 404 for https://example.com/big.png%202x,%20https://example.com/small.png%201x
@paulroub
Copy link
Contributor Author

PR #851 addresses this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant