split TextInputComponent::process_inputs into separate methods #2503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've
stolenborrowed the code that handles key combos fortui_textarea
to my own project, in the process I've split it into multiple functions:process_command_key
- handling Ctrlprocess_meta_key
- handling Altprocess_meta_command_key
- Ctrl + Altprocess_non_modded
- no modifiersI'm not sure if this is a good idea, up to you to decide.
I've double checked if all the keys that were handled before this change are also handled afterwards.
Pros:
In my opinion code is cleaner / easier to read:
Cons:
repeating functionality occurs in multiple methods:
P.S. I've been looking at the project in 2021, it's nice to see how it progressed.
I followed the checklist:
make check
without errors