Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Config Commit Comments #2145

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Conversation

Concelare
Copy link
Contributor

@Concelare Concelare commented Mar 22, 2024

This Pull Request fixes/closes #2136.

It changes the following:

  • Commits will now follow the git config core.commentChar if one is not set it defaults to #

Screenshot Evidence
image

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Concelare and others added 5 commits March 20, 2024 20:58
- Commit Comments Will Now Respect the Comments Prefix in the Config
- No longer uses unwrap()
- Conversion to u8
- Nullable error when core.commentChar is not set
- Using getter instead of index access
- Unneeded usage of char::from()
- Uses Map instead of double unwrap
@extrawurst extrawurst merged commit b15c864 into gitui-org:master Mar 22, 2024
18 checks passed
@extrawurst
Copy link
Collaborator

Thank you @Concelare 🥳

@extrawurst
Copy link
Collaborator

@Concelare please add an entry to the changelog next time too

hendrikmaus added a commit to hendrikmaus/gitui that referenced this pull request Mar 23, 2024
…signing

* 'master' of github.com:extrawurst/gitui: (52 commits)
  Git Config Commit Comments (gitui-org#2145)
  update changelog for 0.25.2
  fix another github action warning
  upgrade version
  prepare release
  preapre for release
  changelog
  fixes tag annotation being broken in 0.25 (gitui-org#2139)
  update changelog
  fix: 2114
  Bump backtrace from 0.3.69 to 0.3.70
  Fixed: - Cargo clippy errors
  cargo updates
  cargo update
  todo
  update changelog
  fix: index out of bounds when blaming a file ending with a blank line (gitui-org#2130)
  Bump bitflags from 2.4.2 to 2.5.0
  Bump clap from 4.5.2 to 4.5.3
  fix chrono deprecations
  ...
extrawurst pushed a commit that referenced this pull request Mar 26, 2024
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit messages that begin with a hash (#) are ignored
2 participants