Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fuzzy find popup scrollable #1734

Merged
merged 9 commits into from
Jul 8, 2023
Merged

Make fuzzy find popup scrollable #1734

merged 9 commits into from
Jul 8, 2023

Conversation

AmmarAbouZor
Copy link
Contributor

@AmmarAbouZor AmmarAbouZor commented Jun 23, 2023 •
edited
Loading

This Pull Request fixes/closes #1732.

It changes the following:

  • It makes the fuzzy-find popup scrollable

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Collaborator

can you add also a scrollbar according to other scrollable content?

@AmmarAbouZor
Copy link
Contributor Author

Scrollbar has been added and it will be rendered only when needed (When the matches list length is bigger than the list height)

@extrawurst
Copy link
Collaborator

Screenshot 2023-06-25 at 18 44 48
  • something seems off if you compare the two colors
  • the scrollbar should go on the border as in other examples

@AmmarAbouZor
Copy link
Contributor Author

  • Sorry I didn't notice the error the position of the scrollbar. It's fixed now.
  • Fixing the position led to fixing the coloring on my machine. I tested it with Alacritty, Kitty, XFCE Terminal.

@AmmarAbouZor AmmarAbouZor requested a review from extrawurst June 30, 2023 06:57
@AmmarAbouZor
Copy link
Contributor Author

Merge conflicts with master has been resolved 👍

@extrawurst extrawurst merged commit 4682a1b into gitui-org:master Jul 8, 2023
@extrawurst
Copy link
Collaborator

Thank you ❤️

@AmmarAbouZor AmmarAbouZor deleted the fix_fuzzy_finder_scroll branch July 8, 2023 16:33
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
@AmmarAbouZor @IndianBoy42
Make fuzzy find popup scrollable (gitui-org#1734)
d877ff1 
* Added: Make fuzzy find popup scrollable
* Fuzzy_find: Add scrollbar to matches list
* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrawurst extrawurst Awaiting requested review from extrawurst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make fuzzy-find-popup scrollable
2 participants
@AmmarAbouZor @extrawurst