Fix - stashlist removes marked commit IDs from state after stash drop #1201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes issue related to dropping multiple stashes (no issue number as far as I can tell). Once we drop marked stash, GitUI's state becomes invalid and the user is not able to drop/pop stash anymore. The scenario is covered in the gif below (after dropping, there remains 1 stash commit in the marked commits state).
It changes the following:
Fixes the described problem.
I followed the checklist:
make check
without errorsI'll add unittests (not sure how should I test it tbh) and changelog later if this fix makes sense.