Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - stashlist removes marked commit IDs from state after stash drop #1201

Closed
wants to merge 1 commit into from
Closed

Conversation

lightsnowball
Copy link
Contributor

This Pull Request fixes issue related to dropping multiple stashes (no issue number as far as I can tell). Once we drop marked stash, GitUI's state becomes invalid and the user is not able to drop/pop stash anymore. The scenario is covered in the gif below (after dropping, there remains 1 stash commit in the marked commits state).

gitui

It changes the following:
Fixes the described problem.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

I'll add unittests (not sure how should I test it tbh) and changelog later if this fix makes sense.

@extrawurst
Copy link
Collaborator

thanks for discovering the bug, your solution to fix it was way too complicated for me to understand. please don't take this personally and use the opportunity to check how I fixed it in #1207

@extrawurst extrawurst closed this Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants