Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor AsyncTags to use AsyncJob #757

Closed
extrawurst opened this issue Jun 1, 2021 · 6 comments
Closed

refactor AsyncTags to use AsyncJob #757

extrawurst opened this issue Jun 1, 2021 · 6 comments
Labels
dormant Marked by stale bot on close enhancement New feature or request good first issue Good for newcomers

Comments

@extrawurst
Copy link
Collaborator

extrawurst commented Jun 1, 2021

we have a lot of code duplication in the async implementations in the root of asyncgit/src/*. for a while we now have a unified abstraction that can be used instead: AsyncJob this is used already in AsyncRemoteTagsJob and AsyncSyntaxJob.

Lets one-by-one cleanup the other places starting with AsyncTags

@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Jun 1, 2021
@mvaneijk
Copy link
Contributor

I would like to give this a try. It will be my first contribution to a rust project.

@extrawurst
Copy link
Collaborator Author

@mvaneijk may I suggest to start with asyncgit/src/tags.rs? It is essentially the same change but much less code, so probably a less daunting entry

@extrawurst extrawurst changed the title refactor AsyncDiff to use AsyncJob refactor AsyncTags to use AsyncJob Aug 22, 2021
@extrawurst
Copy link
Collaborator Author

@mvaneijk I added a more elaborate description above. hope that gives you a good place to start 👍

@mvaneijk
Copy link
Contributor

@extrawurst Looks good, I'll give it a go.

mvaneijk added a commit to mvaneijk/gitui that referenced this issue Aug 28, 2021
@stale

This comment has been minimized.

@stale stale bot added the dormant Marked by stale bot on close label Nov 20, 2021
@extrawurst extrawurst mentioned this issue Nov 20, 2021
3 tasks
@extrawurst extrawurst removed the dormant Marked by stale bot on close label Nov 20, 2021
@stale
Copy link

stale bot commented May 31, 2022

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label May 31, 2022
@stale stale bot closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dormant Marked by stale bot on close enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants