Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VAlert): improve alert accessibility #162

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix(VAlert): improve alert accessibility #162

merged 1 commit into from
Mar 27, 2023

Conversation

gravitano
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Improve alert accessibility by adding `role="alert".

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@gravitano gravitano marked this pull request as ready for review March 27, 2023 05:28
@gravitano gravitano merged commit 89f8001 into main Mar 27, 2023
@gravitano gravitano deleted the fix/alert-role branch March 27, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gravitano