-
Notifications
You must be signed in to change notification settings - Fork 60.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages: misleading description about deprecated code highlighter pygments
#30152
Comments
pygments
pygments
👋 @muzimuzhi Thanks so much for opening an issue! I'll get this triaged for review ✨ |
This comment was marked as spam.
This comment was marked as spam.
1 similar comment
This comment was marked as spam.
This comment was marked as spam.
@muzimuzhi 👋 Thanks for opening this issue and contributing to our Docs, we really appreciate it. It looks like everything after the comma can be can be removed:
So it reads:
You or anyone else is welcome to open a PR. 🔨 |
@sophietheking Actually I think the compatibility bit is important, so I've kept it in #31808 — otherwise agree. |
@janbrasna Agreed with you. And thank you. |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll#syntax-highlighting
What part(s) of the article would you like to see updated?
Currently the section "Syntax highlighting" says
This may mislead readers that GitHub Pages already uses Jekyll 4, while actually it still uses Jekyll 3.9.3. See
Additional information
What "Pygments has been deprecated and not supported in Jekyll 4." (added in 724a274) said is true, but it's not the appropriate reason.
pgyments
was deprecated because GitHub Pages wanted to, not because the version of Jekyll used by GitHub Pages dropped support for it.Pygments support was dropped
github-pages
gem package v44 on 2016-02-02 andThe text was updated successfully, but these errors were encountered: