Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts doesn't work in GUI with non-English keyboard layout #2082

Closed
1 task done
redmanmale opened this issue Feb 22, 2019 · 4 comments
Closed
1 task done

Shortcuts doesn't work in GUI with non-English keyboard layout #2082

redmanmale opened this issue Feb 22, 2019 · 4 comments

Comments

@redmanmale
Copy link

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
$ git --version --build-options
git version 2.20.1.windows.1
cpu: x86_64
built from commit: 7c9fbc07db0e2939b36095df45864b8cda19b64f
sizeof-long: 4
sizeof-size_t: 8
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver
Microsoft Windows [Version 10.0.17134.523]

x64

  • What options did you set as part of the installation? Or did you choose the
    defaults?
# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: VIM
Custom Editor Path: 
Path Option: Cmd
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: CRLFCommitAsIs
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Disabled
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

No.

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Git GUI

Open Git GUI in repo with some edited files.
Select one of them in Unstaged Changes panel and press CTRL-T.

I could provide screenplay (gif) if it's necessary.

  • What did you expect to occur after running these commands?

Stage selected file.

  • What actually happened instead?

Nothing.

  • If the problem was occurring with a specific repository, can you provide the
    URL to that repository to help us with testing?

Any repo.

This behavior only occurs with non-English keyboard layout.
If I switch my keyboard to English (in language settings) everything works just right.

@dscho
Copy link
Member

dscho commented Feb 26, 2019

Okay, this will require a bit of effort on your side just to investigate, as I cannot reproduce the problem here (I tried with a German keyboard and your reported problem does not occur here).

So save this Tcl script under any file name, and run wish <filename>:

set keysym "Press any key...          "
pack [label .l -textvariable keysym -padx 2m -pady 1m]

# Bind an action to any key
bind . <Key> {
    set keysym "You pressed another key (%K)"
}

# Bind an action to Ctrl+T
bind . <Control-Key-t> {
    set keysym "YEP! You pressed Ctrl+%K"
}

I assume you understand what this does, as it is relatively easy to understand.

Then try to hit Ctrl+T and see whether it shows the second message rather than the first. If it does not, you will have to dig in from there, to find out what code path it takes instead.

Good luck!

@redmanmale
Copy link
Author

English keyboard: YEP! You pressed Ctrl+T.
Russian keyboard:
image

@dscho
Copy link
Member

dscho commented Feb 26, 2019

@redmanmale okay, so there you have the problem, and I wish you good luck finding out more about the issue. This is your investigation to drive.

@dscho
Copy link
Member

dscho commented Feb 26, 2019

@redmanmale you might be interested in looking here: https://core.tcl.tk/tk/tktview/62f1343ad2fd9c77d1f3

@dscho dscho closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants