Skip to content

Commit e3ca982

Browse files
committed
mingw: ensure valid CTYPE
A change between versions 2.4.1 and 2.6.0 of the MSYS2 runtime modified how Cygwin's runtime (and hence Git for Windows' MSYS2 runtime derivative) handles locales: d16a56306d (Consolidate wctomb/mbtowc calls for POSIX-1.2008, 2016-07-20). An unintended side-effect is that "cold-calling" into the POSIX emulation will start with a locale based on the current code page, something that Git for Windows is very ill-prepared for, as it expects to be able to pass a command-line containing non-ASCII characters to the shell without having those characters munged. One symptom of this behavior: when `git clone` or `git fetch` shell out to call `git-upload-pack` with a path that contains non-ASCII characters, the shell tried to interpret the entire command-line (including command-line parameters) as executable path, which obviously must fail. This fixes #1036 Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 787bfe4 commit e3ca982

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

compat/mingw.c

+3
Original file line numberDiff line numberDiff line change
@@ -2645,6 +2645,9 @@ static void setup_windows_environment(void)
26452645
if (!tmp && (tmp = getenv("USERPROFILE")))
26462646
setenv("HOME", tmp, 1);
26472647
}
2648+
2649+
if (!getenv("LC_ALL") && !getenv("LC_CTYPE") && !getenv("LANG"))
2650+
setenv("LC_CTYPE", "C.UTF-8", 1);
26482651
}
26492652

26502653
static PSID get_current_user_sid(void)

0 commit comments

Comments
 (0)