Skip to content

Commit de85351

Browse files
committed
Merge pull request #1344 from jeffhostetler/perf_add_excludes_with_fscache
dir.c: make add_excludes aware of fscache during status
2 parents f4a3b37 + 79fcfd4 commit de85351

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed

compat/win32/fscache.c

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ static struct hashmap map;
99
static CRITICAL_SECTION mutex;
1010
static struct trace_key trace_fscache = TRACE_KEY_INIT(FSCACHE);
1111

12+
int fscache_is_enabled(void)
13+
{
14+
return enabled;
15+
}
16+
1217
/*
1318
* An entry in the file system cache. Used for both entire directory listings
1419
* and file entries.

compat/win32/fscache.h

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
int fscache_enable(int enable);
55
#define enable_fscache(x) fscache_enable(x)
66

7+
int fscache_is_enabled(void);
8+
#define is_fscache_enabled() (fscache_is_enabled())
9+
710
DIR *fscache_opendir(const char *dir);
811
int fscache_lstat(const char *file_name, struct stat *buf);
912

dir.c

+3-2
Original file line numberDiff line numberDiff line change
@@ -805,8 +805,9 @@ static int add_excludes(const char *fname, const char *base, int baselen,
805805
size_t size = 0;
806806
char *buf;
807807

808-
fd = open(fname, O_RDONLY);
809-
if (fd < 0 || fstat(fd, &st) < 0) {
808+
if (is_fscache_enabled() && lstat(fname, &st) < 0)
809+
return -1;
810+
if ((fd = open(fname, O_RDONLY)) < 0 || fstat(fd, &st) < 0) {
810811
if (fd < 0)
811812
warn_on_fopen_errors(fname);
812813
else

git-compat-util.h

+4
Original file line numberDiff line numberDiff line change
@@ -1255,6 +1255,10 @@ static inline int is_missing_file_error(int errno_)
12551255
#define enable_fscache(x) /* noop */
12561256
#endif
12571257

1258+
#ifndef is_fscache_enabled
1259+
#define is_fscache_enabled() (0)
1260+
#endif
1261+
12581262
extern int cmd_main(int, const char **);
12591263

12601264
/*

0 commit comments

Comments
 (0)