Skip to content

Commit c56c196

Browse files
committed
mingw: allow absolute paths without drive prefix
When specifying an absolute path without a drive prefix, we convert that path internally. Let's make sure that we handle that case properly, too ;-) This fixes the command git clone https://github.com/git-for-windows/git \G4W Signed-off-by: Johannes Schindelin <[email protected]>
1 parent f111b13 commit c56c196

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

compat/mingw.c

+9-1
Original file line numberDiff line numberDiff line change
@@ -1052,11 +1052,19 @@ unsigned int sleep (unsigned int seconds)
10521052
char *mingw_mktemp(char *template)
10531053
{
10541054
wchar_t wtemplate[MAX_PATH];
1055+
int offset = 0;
1056+
10551057
if (xutftowcs_path(wtemplate, template) < 0)
10561058
return NULL;
1059+
1060+
if (is_dir_sep(template[0]) && !is_dir_sep(template[1]) &&
1061+
iswalpha(wtemplate[0]) && wtemplate[1] == L':') {
1062+
/* We have an absolute path missing the drive prefix */
1063+
offset = 2;
1064+
}
10571065
if (!_wmktemp(wtemplate))
10581066
return NULL;
1059-
if (xwcstoutf(template, wtemplate, strlen(template) + 1) < 0)
1067+
if (xwcstoutf(template, wtemplate + offset, strlen(template) + 1) < 0)
10601068
return NULL;
10611069
return template;
10621070
}

t/t5580-unc-paths.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ case "$UNCPATH" in
3333
;;
3434
esac
3535

36-
test_expect_failure 'clone into absolute path lacking a drive prefix' '
36+
test_expect_success 'clone into absolute path lacking a drive prefix' '
3737
USINGBACKSLASHES="$(echo "$WITHOUTDRIVE"/without-drive-prefix |
3838
tr / \\\\)" &&
3939
git clone . "$USINGBACKSLASHES" &&

0 commit comments

Comments
 (0)