Skip to content

Commit beb17da

Browse files
kbleesdscho
authored andcommitted
Win32: make the lstat implementation pluggable
Emulating the POSIX lstat API on Windows via GetFileAttributes[Ex] is quite slow. Windows operating system APIs seem to be much better at scanning the status of entire directories than checking single files. A caching implementation may improve performance by bulk-reading entire directories or reusing data obtained via opendir / readdir. Make the lstat implementation pluggable so that it can be switched at runtime, e.g. based on a config option. Signed-off-by: Karsten Blees <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
1 parent b280eef commit beb17da

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

compat/mingw.c

+2
Original file line numberDiff line numberDiff line change
@@ -904,6 +904,8 @@ static int do_stat_internal(int follow, const char *file_name, struct stat *buf)
904904
return do_lstat(follow, alt_name, buf);
905905
}
906906

907+
int (*lstat)(const char *file_name, struct stat *buf) = mingw_lstat;
908+
907909
static int get_file_info_by_handle(HANDLE hnd, struct stat *buf)
908910
{
909911
BY_HANDLE_FILE_INFORMATION fdata;

compat/mingw.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ int mingw_fstat(int fd, struct stat *buf);
417417
#ifdef lstat
418418
#undef lstat
419419
#endif
420-
#define lstat mingw_lstat
420+
extern int (*lstat)(const char *file_name, struct stat *buf);
421421

422422

423423
int mingw_utime(const char *file_name, const struct utimbuf *times);

0 commit comments

Comments
 (0)