Skip to content

Commit 572dc1b

Browse files
author
Git for Windows Build Agent
committed
Merge branch 'resource-version'
This topic branch increases the precision of the version recorded in the resources of the .exe files from major/minor to include also the micro version and the patch level. Signed-off-by: Johannes Schindelin <[email protected]>
2 parents 8107f15 + 2a3d239 commit 572dc1b

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

Makefile

+7-2
Original file line numberDiff line numberDiff line change
@@ -1792,9 +1792,14 @@ $(SCRIPT_LIB) : % : %.sh GIT-SCRIPT-DEFINES
17921792
$(QUIET_GEN)$(cmd_munge_script) && \
17931793
mv $@+ $@
17941794

1795+
ifeq (,$(findstring .windows.,$(GIT_VERSION)))
1796+
RC_VERSION_DEFS := $(join -DMAJOR= -DMINOR= -DMICRO=, $(wordlist 1,3,$(subst -, ,$(subst ., ,$(subst .windows., ,$(GIT_VERSION)))))) -DPATCHLEVEL=0
1797+
else
1798+
RC_VERSION_DEFS := $(join -DMAJOR= -DMINOR= -DMICRO= -DPATCHLEVEL=, $(wordlist 1,4,$(subst -, ,$(subst ., ,$(subst .windows., ,$(GIT_VERSION))))))
1799+
endif
1800+
17951801
git.res: git.rc GIT-VERSION-FILE GIT-PREFIX
1796-
$(QUIET_RC)$(RC) \
1797-
$(join -DMAJOR= -DMINOR=, $(wordlist 1,2,$(subst -, ,$(subst ., ,$(GIT_VERSION))))) \
1802+
$(QUIET_RC)$(RC) $(RC_VERSION_DEFS) \
17981803
-DGIT_VERSION="\\\"$(GIT_VERSION)\\\"" $< -o $@
17991804

18001805
# This makes sure we depend on the NO_PERL setting itself.

git.rc

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
1 VERSIONINFO
2-
FILEVERSION MAJOR,MINOR,0,0
3-
PRODUCTVERSION MAJOR,MINOR,0,0
2+
FILEVERSION MAJOR,MINOR,MICRO,PATCHLEVEL
3+
PRODUCTVERSION MAJOR,MINOR,MICRO,PATCHLEVEL
44
BEGIN
55
BLOCK "StringFileInfo"
66
BEGIN

0 commit comments

Comments
 (0)