Skip to content

Commit 518ccba

Browse files
committed
mingw: handle a file owned by the Administrators group correctly
When an Administrator creates a file or directory, the created file/directory is owned not by the Administrator SID, but by the _Administrators Group_ SID. The reason is that users with administrator privileges usually run in unprivileged ("non-elevated") mode, and their user SID does not change when running in elevated mode. This is is relevant e.g. when running a GitHub workflow on a build agent, which runs in elevated mode: cloning a Git repository in a script step will cause the worktree to be owned by the Administrators Group SID, for example. Let's handle this case as following: if the current user is an administrator, Git should consider a worktree owned by the Administrators Group as if it were owned by said user. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 6c07169 commit 518ccba

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

compat/mingw.c

+10
Original file line numberDiff line numberDiff line change
@@ -3499,6 +3499,7 @@ int is_path_owned_by_current_sid(const char *path)
34993499
else if (sid && IsValidSid(sid)) {
35003500
/* Now, verify that the SID matches the current user's */
35013501
static PSID current_user_sid;
3502+
BOOL is_member;
35023503

35033504
if (!current_user_sid)
35043505
current_user_sid = get_current_user_sid();
@@ -3507,6 +3508,15 @@ int is_path_owned_by_current_sid(const char *path)
35073508
IsValidSid(current_user_sid) &&
35083509
EqualSid(sid, current_user_sid))
35093510
result = 1;
3511+
else if (IsWellKnownSid(sid, WinBuiltinAdministratorsSid) &&
3512+
CheckTokenMembership(NULL, sid, &is_member) &&
3513+
is_member)
3514+
/*
3515+
* If owned by the Administrators group, and the
3516+
* current user is an administrator, we consider that
3517+
* okay, too.
3518+
*/
3519+
result = 1;
35103520
else if (git_env_bool("GIT_TEST_DEBUG_UNSAFE_DIRECTORIES", 0)) {
35113521
LPSTR str1, str2, to_free1 = NULL, to_free2 = NULL;
35123522

0 commit comments

Comments
 (0)