From ad2b08dba8e7834fd6a167c6f22a6188719e30e2 Mon Sep 17 00:00:00 2001
From: Audric Guerin <49029709+AudricGuerin@users.noreply.github.com>
Date: Fri, 20 Sep 2019 03:50:37 +0200
Subject: [PATCH] fix installer's Product Version inconsistency with older
 versions

Why: Third-party applications or IT tools must be able to know
if the latest Git version is installed on the system
by means of version number comparisons.

How: Remove platform identifier from the Product Version.

Product Version now displays x.x.x.x instead of x.x.x.windows.x

See https://github.com/git-for-windows/git/issues/2223

Remarks:
Project's binaries Product Version are unchanged by this commit (only the installer's one)
Git internal versioning is left untouched ; 'git version' still returns x.x.x.windows.x (this commit addresses versioning issue from the OS point of view so the installer executable is the only file affected by this commit)

Signed-off-by: Audric Guerin <49029709+AudricGuerin@users.noreply.github.com>
---
 installer/install.iss | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/installer/install.iss b/installer/install.iss
index 7183842d7d..72cc8cb7c4 100644
--- a/installer/install.iss
+++ b/installer/install.iss
@@ -50,8 +50,6 @@ SignTool=signtool
 #endif
 
 #define FILE_VERSION GetFileVersion(SOURCE_DIR+'\'+MINGW_BITNESS+'\bin\git.exe')
-#define PROD_VERSION GetStringFileInfo(SOURCE_DIR+'\'+MINGW_BITNESS \
-				+'\bin\git.exe', 'ProductVersion')
 
 ; Installer-related
 AllowNoIcons=yes
@@ -59,7 +57,7 @@ AppName={#APP_NAME}
 AppPublisher=The Git Development Community
 AppPublisherURL={#APP_URL}
 AppSupportURL={#APP_CONTACT_URL}
-AppVersion={#PROD_VERSION}
+AppVersion={#APP_VERSION}
 ChangesAssociations=yes
 ChangesEnvironment=yes
 CloseApplications=no