fix installer's Product Version inconsistency with older versions

Why: Third-party applications or IT tools must be able to know
if the latest Git version is installed on the system
by means of version number comparisons.

How: Remove platform identifier from the Product Version.

Product Version now displays x.x.x.x instead of x.x.x.windows.x

See git-for-windows/git#2223

Remarks:
Project's binaries Product Version are unchanged by this commit (only the installer's one)
Git internal versioning is left untouched ; 'git version' still returns x.x.x.windows.x (this commit addresses versioning issue from the OS point of view so the installer executable is the only file affected by this commit)

Signed-off-by: Audric Guerin <[email protected]>

Author: AudricGuerin

installer/install.iss

@@ -50,16 +50,14 @@ SignTool=signtool
 #endif
 
 #define FILE_VERSION GetFileVersion(SOURCE_DIR+'\'+MINGW_BITNESS+'\bin\git.exe')
-#define PROD_VERSION GetStringFileInfo(SOURCE_DIR+'\'+MINGW_BITNESS \
-				+'\bin\git.exe', 'ProductVersion')
 
 ; Installer-related
 AllowNoIcons=yes
 AppName={#APP_NAME}
 AppPublisher=The Git Development Community
 AppPublisherURL={#APP_URL}
 AppSupportURL={#APP_CONTACT_URL}
-AppVersion={#PROD_VERSION}
+AppVersion={#APP_VERSION}
 ChangesAssociations=yes
 ChangesEnvironment=yes
 CloseApplications=no