Skip to content

Commit 8d01cee

Browse files
authored
Merge pull request #355 from rimrul/sublime4
installer: Support Sublime Text 4 and (probably) newer
2 parents abfa6c1 + ba0653f commit 8d01cee

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

ReleaseNotes.md

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ This package contains software from a number of other projects including Bash, z
4949
* Comes with [PCRE2 v10.37](https://pcre.org/news.txt).
5050
* The experimental, built-in file system monitor [is now featured as an experimental option in the installer](https://github.com/git-for-windows/build-extra/pull/351).
5151
* Comes with [Git Credential Manager Core v2.0.474.41365](https://github.com/microsoft/git-credential-manager-core/releases/tag/v2.0.474).
52+
* Sublime Text 4 [now gets detected by the installer](https://github.com/git-for-windows/build-extra/pull/355).
5253

5354
### Bug Fixes
5455

installer/install.iss

+7-3
Original file line numberDiff line numberDiff line change
@@ -1810,11 +1810,15 @@ begin
18101810
EditorAvailable[GE_VisualStudioCodeInsiders]:=RegQueryStringValue(HKEY_CURRENT_USER,'Software\Classes\Applications\Code - Insiders.exe\shell\open\command','',VisualStudioCodeInsidersPath);
18111811
VisualStudioCodeInsidersUserInstallation:=True;
18121812
end;
1813-
SublimeTextPath:=ExpandConstant('{pf}\Sublime Text 3\subl.exe');
1813+
SublimeTextPath:=ExpandConstant('{pf}\Sublime Text\subl.exe');
18141814
EditorAvailable[GE_SublimeText]:=PathIsValidExecutable(SublimeTextPath);
18151815
if (not EditorAvailable[GE_SublimeText]) then begin
1816-
EditorAvailable[GE_SublimeText]:=RegQueryStringValue(HKEY_CURRENT_USER,'Software\Classes\Applications\sublime_text.exe\shell\open\command','',SublimeTextPath);
1817-
SublimeTextUserInstallation:=True;
1816+
SublimeTextPath:=ExpandConstant('{pf}\Sublime Text 3\subl.exe');
1817+
EditorAvailable[GE_SublimeText]:=PathIsValidExecutable(SublimeTextPath);
1818+
if (not EditorAvailable[GE_SublimeText]) then begin
1819+
EditorAvailable[GE_SublimeText]:=RegQueryStringValue(HKEY_CURRENT_USER,'Software\Classes\Applications\sublime_text.exe\shell\open\command','',SublimeTextPath);
1820+
SublimeTextUserInstallation:=True;
1821+
end;
18181822
end;
18191823
EditorAvailable[GE_Atom]:=RegQueryStringValue(HKEY_CURRENT_USER,'Software\Classes\Applications\atom.exe\shell\open\command','',AtomPath);
18201824
EditorAvailable[GE_CustomEditor]:=True;

0 commit comments

Comments
 (0)