Skip to content

Commit 4c195f4

Browse files
Samuel Lijindscho
Samuel Lijin
authored andcommitted
installer: do not leave empty directories behind
When uninstalling Git for Windows, a C:\Program Files\Git\mingw64 folder was left behind, with no files in it, leading to problems for subsequent installations (that would ask whether the user wants to overwrite any existing installation). First noticed when uninstalling v2.10.1, after installing v2.10.0 with admin privileges to %PROGRAMFILES%/Git and upgrading to v2.10.1 on Windows 7 x64, that the uninstaller did not clean up %PROGRAMFILES%/Git nor %PROGRAMFILES%/Git/mingw64. This fixes git-for-windows/git#909 [JES: touched up commit message; SOB not needed, as I suggested the patch to begin with] Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 13b6252 commit 4c195f4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

installer/install.iss

+2
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,8 @@ Type: dirifempty; Name: {app}\etc
236236
; Delete recorded install options
237237
Type: files; Name: {app}\etc\install-options.txt
238238
Type: dirifempty; Name: {app}\etc
239+
Type: dirifempty; Name: {app}\{#MINGW_BITNESS}
240+
Type: dirifempty; Name: {app}
239241

240242
[Code]
241243
#include "helpers.inc.iss"

0 commit comments

Comments
 (0)