Skip to content

Commit 1e2e00e

Browse files
committed
installer: add git.exe to the PATH by default, ignoring previous settings
Most users simply click through the installer and do not benefit from our previous change that added `cmd/` to the PATH enabled by default, because during an upgrade the previous setting (which was disabled by default) would be replayed. Let's skip replaying the previous setting for a couple of releases so that users get to benefit from the new default. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 95e4d28 commit 1e2e00e

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

installer/install.iss

+1-12
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,6 @@ begin
626626
Height:=ScaleY(17);
627627
Font.Style:=[fsBold];
628628
TabOrder:=0;
629-
Checked:=True;
630629
end;
631630
LblGitBash:=TLabel.Create(PathPage);
632631
with LblGitBash do begin
@@ -651,6 +650,7 @@ begin
651650
Height:=ScaleY(17);
652651
Font.Style:=[fsBold];
653652
TabOrder:=1;
653+
Checked:=True;
654654
end;
655655
LblGitCmd:=TLabel.Create(PathPage);
656656
with LblGitCmd do begin
@@ -700,17 +700,6 @@ begin
700700
Font.Style:=[fsBold];
701701
end;
702702
703-
// Restore the setting chosen during a previous install.
704-
Data:=ReplayChoice('Path Option','Cmd');
705-
706-
if Data='BashOnly' then begin
707-
RdbPath[GP_BashOnly].Checked:=True;
708-
end else if Data='Cmd' then begin
709-
RdbPath[GP_Cmd].Checked:=True;
710-
end else if Data='CmdTools' then begin
711-
RdbPath[GP_CmdTools].Checked:=True;
712-
end;
713-
714703
(*
715704
* Create a custom page for using (Tortoise)Plink instead of OpenSSH
716705
* if at least one PuTTY session is found in the Registry.

0 commit comments

Comments
 (0)