Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian package is missing new UI helper executables #387

Closed
mjcheetham opened this issue Jul 1, 2021 · 0 comments · Fixed by #405
Closed

Debian package is missing new UI helper executables #387

mjcheetham opened this issue Jul 1, 2021 · 0 comments · Fixed by #405
Assignees
@vdye
Labels
bug A bug in Git Credential Manager good-first-issue A good issue or enhancement for a first time contributor installation Specific to installation and uninstallation platform:linux Specific to a Linux-based platform

Comments

@mjcheetham
Copy link
Collaborator

Although the Linux tarball (.tar.gz) release assets contain all the required executables, the Debian package (.deb) only contains the main git-credential-manager-core executable and is missing the UI helpers such as GitHub.UI and Atlassian.Bitbucket.UI.

The issue is here..
https://github.com/microsoft/Git-Credential-Manager-Core/blob/4706801d29038f429bc15353eec4c85f0ac4241b/src/linux/Packaging.Linux/build.sh#L175-L176

..we're not copying all the binaries.

While we're here, we might want to consider installing the binaries somewhere else (like in /usr/[local/]bin/share/gcm-core like we do on macOS) and instead create symlinks to /usr/bin.
@mjcheetham mjcheetham added bug A bug in Git Credential Manager platform:linux Specific to a Linux-based platform installation Specific to installation and uninstallation labels Jul 1, 2021
@mjcheetham mjcheetham added the good-first-issue A good issue or enhancement for a first time contributor label Jul 22, 2021
@vdye vdye mentioned this issue Aug 5, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdye vdye

Labels
bug A bug in Git Credential Manager good-first-issue A good issue or enhancement for a first time contributor installation Specific to installation and uninstallation platform:linux Specific to a Linux-based platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add UI helpers to .deb package & change install location w/ symlinking vdye/git-credential-manager
2 participants
@vdye @mjcheetham