Merge pull request #243 from mjcheetham/noboxchars

Remove use of box drawing characters in warning output

Author: mjcheetham

src/shared/Microsoft.Git.CredentialManager/HttpClientFactory.cs

@@ -72,9 +72,9 @@ public HttpClient CreateClient()
             if (!_settings.IsCertificateVerificationEnabled)
             {
                 _trace.WriteLine("TLS certificate verification has been disabled.");
-                _streams.Error.WriteLine("warning: ┌──────────────── SECURITY WARNING ───────────────┐");
-                _streams.Error.WriteLine("warning: │ TLS certificate verification has been disabled! │");
-                _streams.Error.WriteLine("warning: └─────────────────────────────────────────────────┘");
+                _streams.Error.WriteLine("warning: ----------------- SECURITY WARNING ----------------");
+                _streams.Error.WriteLine("warning: | TLS certificate verification has been disabled! |");
+                _streams.Error.WriteLine("warning: ---------------------------------------------------");
                 _streams.Error.WriteLine($"warning: HTTPS connections may not be secure. See {Constants.HelpUrls.GcmTlsVerification} for more information.");
 
 #if NETFRAMEWORK

src/shared/Microsoft.Git.CredentialManager/Settings.cs

@@ -277,18 +277,18 @@ public bool IsInteractionAllowed
                      * We've slightly changed the behaviour of this setting in GCM Core to essentially
                      * remove the 'always' option. The table below outlines the changes:
                      *
-                     * ┌──────────┬───────────────────────────┬────────────────────┐
-                     * │ Value(s) │ Old meaning               │ New meaning        │
-                     * ┝━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━┥
-                     * │ auto     │ Prompt if required        │ [unchanged]        │
-                     * ├──────────┼───────────────────────────┼────────────────────┤
-                     * │ never    │ Never prompt ─ fail if    │ [unchanged]        │
-                     * │ false    │ interaction is required   │                    │
-                     * ├──────────┼───────────────────────────┼────────────────────┤
-                     * │ always   │ Always prompt ─ don't use │ Prompt if required │
-                     * │ force    │ cached credentials        │                    │
-                     * │ true     │                           │                    │
-                     * └──────────┴───────────────────────────┴────────────────────┘
+                     * -------------------------------------------------------------
+                     * | Value(s) | Old meaning               | New meaning        |
+                     * |-----------------------------------------------------------|
+                     * | auto     | Prompt if required        | [unchanged]        |
+                     * |-----------------------------------------------------------|
+                     * | never    | Never prompt ─ fail if    | [unchanged]        |
+                     * | false    | interaction is required   |                    |
+                     * |-----------------------------------------------------------|
+                     * | always   | Always prompt ─ don't use | Prompt if required |
+                     * | force    | cached credentials        |                    |
+                     * | true     |                           |                    |
+                     * -------------------------------------------------------------
                      */
                     if (StringComparer.OrdinalIgnoreCase.Equals("never", value))
                     {