Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standarization of the registry domain config value for catalogs+apps #3179

Open
Tracked by #2882
piontec opened this issue Jan 23, 2024 · 3 comments
Open
Tracked by #2882

standarization of the registry domain config value for catalogs+apps #3179

piontec opened this issue Jan 23, 2024 · 3 comments
Labels

Comments

@piontec
Copy link

piontec commented Jan 23, 2024

We use many different values in the values.yaml file of our helm charts to indicate the registry DNS domain that the images should come from. We have to come up with a single standard configuration layout that has to be implemented by all apps.

Lack of this standard is a problem, because:

  • there's no single way to do it. Currently, we identified at lest 6 different approaches. Now, when we want to switch the registry domain globally by using the catalogs' config, there's a lot of duplication.
  • some apps (*-cluster-apps) use strict values.yaml schema validation. Until we have a standard about it, there's again a ton of duplication we have to introduce to make them work (we push all the values to all the apps) and still some app's config can break it
@piontec
Copy link
Author

piontec commented Feb 1, 2024

blocked by #3185

@nprokopic
Copy link

nprokopic commented Feb 7, 2024

some apps (*-cluster-apps) use strict values.yaml schema validation. Until we have a standard about it, there's again a ton of duplication we have to introduce to make them work (we push all the values to all the apps) and still some app's config can break it

Here if you refer to cluster-<provider> and default-apps-<provider>, see my comment here #3187 (comment)

TL;DR We should make a clear distinction between configuration of "regular" apps (that deploy controllers/operators) and cluster-<provider> (and default-apps-<provider>) apps. They are used for different things and "global" configs (changed "globally") have quite different impacts. Universal config for "regular" apps (that deploy controllers/operators) should IMO not be universal for and shared with cluster-<provider> (and default-apps-<provider>) apps as well.

@mproffitt mproffitt added the needs/rfc We need an RFC document for this label Feb 28, 2024
@weatherhog
Copy link

@teemow teemow moved this from Inbox 📥 to Backlog 📦 in Roadmap Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog 📦
Development

No branches or pull requests

4 participants