Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typing): add missing item metadata interface #299

Merged
merged 4 commits into from
Mar 30, 2021

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #299 (7c56074) into master (721a6c5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #299   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       212           
  Lines        12715     12716    +1     
  Branches      4169      4169           
=========================================
+ Hits         12715     12716    +1     
Impacted Files Coverage Δ
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721a6c5...7c56074. Read the comment docs.

- nonetheless, tsc seems to be doing something wrong here, it should infer that '*' is valid, we'll have to check back in future version of tsc
@ghiscoding ghiscoding merged commit 7cf0a21 into master Mar 30, 2021
@ghiscoding ghiscoding deleted the feat/add-item-metadata-interface branch March 30, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant