Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): Filter & Sorting presets & Footer metrics issues #285

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 15, 2021

  • use onRowCountChanged instead of onRowsOrCountChanged to avoid full grid refresh/re-render
  • input filter should use keyup to clearly identify when to use the filter keyboard debounce (that is relevent to InputFilter & CompoundInputFilter)
  • grid presets of Filter & Sorting should be called even their input are an empty array, this fixes an issue identified when dynamically switching a Grid View (what is shown on Example 11) that includes Filters/Sorting/Columns

- use `onRowCountChanged` instead of `onRowsOrCountChanged` to avoid full grid refresh/re-render
- input filter should use keyup to clearly identify when to use the filter keyboard debounce (that is relevent to InputFilter & CompoundInputFilter)
- grid presets of Filter & Sorting should be called even their input are an empty array, this fixes an issue identified when dynamically switching a Grid View (what is shown on Example 11) that includes Filters/Sorting/Columns
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #285 (fcb0091) into master (bb7dcd3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          209       209           
  Lines        12436     12433    -3     
  Branches      4253      4253           
=========================================
- Hits         12436     12433    -3     
Impacted Files Coverage Δ
packages/common/src/filters/compoundInputFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/inputFilter.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/sort.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7dcd3...fcb0091. Read the comment docs.

@ghiscoding ghiscoding merged commit 3174c86 into master Mar 16, 2021
@ghiscoding ghiscoding deleted the bugfix/on-row-count-changed-refresh-metrics branch March 16, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant