Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exports): Excel Export custom width applies the width to next column #242

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

ghiscoding
Copy link
Owner

- the custom width was not applied to the correct column, when user had a custom width on column 1 it was applied to column 2. The bug was that getGrouping() always return an array and we should check for its length instead (not just if it exist)
- fixes issue report in Aurelia-Slickgrid ghiscoding/aurelia-slickgrid#511
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #242 (cfc7c1f) into master (b5babc3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #242   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        11974     11974           
  Branches      4117      4114    -3     
=========================================
  Hits         11974     11974           
Impacted Files Coverage Δ
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5babc3...cfc7c1f. Read the comment docs.

@ghiscoding ghiscoding merged commit 146f64f into master Jan 26, 2021
@ghiscoding ghiscoding deleted the bugfix/excel-export-custom-width branch January 26, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant