-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sub-menu(s) to CellMenu & ContextMenu plugins #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add sub-menus to all extensions (CellMenu, ContextMenu, GridMenu, HeaderMenu) - currently only works by `click` event on sub-menus, I tried to implement it with `mouseover`/`mouseout` but it's a lot more complex (we need to know if we are mousing over the correct sub-menu or over something else and this and that... wow just too much work)... so `click` should be enough for now, even though it's slightly less user friendly
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 245 245
Lines 16886 16997 +111
Branches 6062 6113 +51
==========================================
+ Hits 16886 16997 +111
|
- use Example 4 for Context Menu w/sub-menus & tests - use Example 6 for Cell Menu w/sub-menus & tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
click
event on sub-menus, themouseover
will be implemented in a future PRTODOS
slick-submenu
class when it's a sub-menuslick-group-level-2
& 2-addlevel="2"
attributesubMenuTitle
&subMenuTitleCssClass
to optionally add sub-menu title & custom stylingsubMenuTitleKey
and also test withtitleKey