Difference between if statement and error message in ggsurv_m

[johan-ejstrud]

When using confidence intervals in a plot with multiple strata in ggsurv(), the error message "Either surv.col or lty.est should be of length 1 in order to plot 95% CI with multiple strata" can be encountered. However, the if statement and the error message does not agree:

if (length(surv.col) > 1 || length(lty.est) > 1) {
   stop("Either surv.col or lty.est should be of length 1 in order to plot 95% CI with multiple strata")

I think that the error message is correct, while the if statement is not. My guess is that the code should be changed to:

if (length(surv.col) != 1 & length(lty.est) != 1) {
   stop("Either surv.col or lty.est should be of length 1 in order to plot 95% CI with multiple strata")

[schloerke]

@EdwinTh

Do you think this error message is needed anymore?

ggally/R/ggsurv.R

Line 295 in 6f96dcf

stop('Either surv.col or lty.est should be of length 1 in order to plot 95% CI with multiple strata')

I think surv.col length check is covered here:

ggally/R/ggsurv.R

Line 274 in 6f96dcf

pl <- if(surv.col[1] != 'gg.def'){

and lty.est length check is covered here:

ggally/R/ggsurv.R

Line 286 in 6f96dcf

lineScaleValues <- if (length(lty.est) == 1) {

If so, we might as well remove the stop check.

[EdwinTh]

I cannot figure out why I introduced the stop check in the first place. Although specifying both multiple surv.col and multiple lty.est gives a bit of a circus, technically there is nothing wrong with it.

The checks you mention, Barret, do not check for the combination of the two parameters, so in that sense the check is not redundant. However I still opt for removing it, because it is for the user to decide if both should be specified.

[schloerke]

removed error check. submitting to cran