Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bit confused about this in function ggml_cl_mul_f32 #2050

Closed
gotope opened this issue Jun 29, 2023 · 4 comments
Closed

a bit confused about this in function ggml_cl_mul_f32 #2050

gotope opened this issue Jun 29, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@gotope
Copy link
Contributor

gotope commented Jun 29, 2023

static void ggml_cl_mul_f32(const ggml_tensor * src0, const ggml_tensor * src1, ggml_tensor * dst) {
GGML_ASSERT(src1->backend == GGML_BACKEND_GPU);
const int64_t ne00 = src0->ne[0];
const int64_t ne01 = src0->ne[1];
const int64_t ne02 = src0->ne[2];
const int64_t ne03 = src0->ne[2]; // is ne03 the same as ne02 ?

@Green-Sky Green-Sky added the bug Something isn't working label Jul 1, 2023
@ggerganov
Copy link
Member

Looks like a bug

@0cc4m
Copy link
Collaborator

0cc4m commented Jul 3, 2023

Yes, this is a bug that has never caused an issue cause we only use 2D matrices at the moment. You can make a PR to fix it or I'll do it eventually.

@gotope
Copy link
Contributor Author

gotope commented Jul 3, 2023

@0cc4m, PR #2088

@howard0su
Copy link
Collaborator

the PR is committed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants