Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matrix ci build #211

Merged
merged 2 commits into from
Feb 8, 2015
Merged

Fix matrix ci build #211

merged 2 commits into from
Feb 8, 2015

Conversation

ggiamarchi
Copy link
Owner

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.81% when pulling b9e30da on fix_matrix_ci_build into 9cdc83b on master.

julienvey
julienvey reviewed Feb 8, 2015
View reviewed changes
.travis.yml
env:
matrix:
- VAGRANT_VERSION=v1.4.3 BUNDLER_VERSION=1.6.6
- VAGRANT_VERSION=v1.5.4 BUNDLER_VERSION=1.5.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why Bundler version is 1.5.2 here, any reason ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before vagrant 1.5.0, bundler was not referenced in the gemspec. In 1.5.x bundler ~> 1.5.2 is required. This means vagrant 1.5.x cannot be built with bundler greater or equals than 1.6.0. Here is what's happen in this case.

I always do things with a reason 😇

julienvey added a commit that referenced this pull request Feb 8, 2015
@julienvey
Merge pull request #211 from ggiamarchi/fix_matrix_ci_build
00f9982 
Fix matrix ci build
@julienvey julienvey merged commit 00f9982 into master Feb 8, 2015
@julienvey julienvey deleted the fix_matrix_ci_build branch February 8, 2015 22:38
Sharpie pushed a commit to Sharpie/vagrant-openstack-provider that referenced this pull request Jan 18, 2016
@julienvey
Merge pull request ggiamarchi#211 from ggiamarchi/fix_matrix_ci_build
b256b80 
Fix matrix ci build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiamarchi @coveralls @julienvey