Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrastive search #133

Open
jafri opened this issue Nov 9, 2022 · 1 comment
Open

Contrastive search #133

jafri opened this issue Nov 9, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jafri
Copy link
Contributor

jafri commented Nov 9, 2022

Thought you would find interesting: https://twitter.com/martin_gorner/status/1590339322992959488

Wonder if applicable to whisper, since currently use Greedy
@ggerganov ggerganov added the enhancement New feature or request label Nov 9, 2022
@ggerganov
Copy link
Owner

Yes - very interesting.

I'll definitely take a more detailed look at the paper and see if we can add this to the project.
I am very hesitant about adding beam search, as I intuitively feel it is wasting too much computation for not-that-great improvement. So any alternative approach is of interest.

@ggerganov ggerganov changed the title Constrastive search Contrastive search Nov 26, 2022
@ggerganov ggerganov mentioned this issue Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggerganov @jafri