Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @react-native-firebase/app and @react-native-firebase/crashlytics in /js #130

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github May 21, 2021

Bumps @react-native-firebase/app and @react-native-firebase/crashlytics. These dependencies needed to be updated together.
Updates @react-native-firebase/app from 10.5.0 to 12.0.0

Release notes

Sourced from @​react-native-firebase/app's releases.

v5.6.0 - Sign-in with Apple support, react-native 0.60+ only

Please note v5 is still seeing releases, but they are for breaking ecosystem changes only - just enough so it remains relevant for those that can't move to v6 yet.

This change allows use of Sign-in with Apple, an iOS13+ requirement to avoid rejection by the App Store if you use any forms of social authentication.

Breaking: Note that iOS13+ is only supported with Xcode 11+, which requires react-native 0.60+

You may find that react-native-firebase v5.6.x still works on react-native 0.59 (the test suite still does), but you will not be able to integrate Sign-in with Apple until you upgrade as that library is react-native 0.60+ only.

It works well with https://github.com/invertase/react-native-apple-authentication including a guide specifically for integrating with react-native-firebase, though note the import statements are for v6, you'll need to import auth in the v5 style to use it: https://github.com/invertase/react-native-apple-authentication/blob/master/docs/FIREBASE.md

See discussion in the related issue: invertase/react-native-firebase#2884

https://rnfirebase.io/docs/v5.x.x/releases/v5.6.x

Changelog

Sourced from @​react-native-firebase/app's changelog.

12.0.0 (2021-05-19)

Features

  • database: add database.useEmulator() (0632ca5)

  • sdks: firebase-ios-sdk 8.0.0 / firebase-android-sdk 28.0.1 (d97587b)

  • storage, emulator: implement storage emulator (1d3e946)

  • storage, md5hash: allow md5hash to be set on upload (be1bed8)

  • chore(storage, android)!: remove EXTERNAL_STORAGE permissions for Android 10/11 compat (69b6f88)

  • feat(firestore)!: add support for ignoreUndefinedProperties (756cfa6)

Bug Fixes

  • android: correct lint issues for various API mis-use (eb8d893), closes #3917
  • storage, android: correctly catch native exceptions for Promise.reject (e938824), closes #4097

BREAKING CHANGES

  • Storage: if you need READ_EXTERNAL_STORAGE/WRITE_EXTERNAL_STORAGE permission add them in your app AndroidManifest.xml
  • Firestore: undefined values throw like firebase-js-sdk now. Use ignoreUndefinedProperties setting 'true' to behave as before
  • AdMob: Removed from upstream SDKs. Stay on v11.5.0 for now if you need AdMob. @invertase/react-native-admob package planned with v11.5.0 code
  • ML: APIs removed from upstream SDKs. Migrate to cloud function / auth gateway to cloud APIs, as mentioned in links on ML usage document.
  • Instance ID: APIs removed from upstream SDKs. Use Messaging's getToken() to get tokens, see upstream documentation to migrate if needed
  • Messaging.getToken/deleteToken: scoped token APIs removed from upstream APIs. Remove scopes from API calls. deleteToken() should work on iOS now.

11.5.0 (2021-05-12)

Bug Fixes

  • admob: mark BannerAd callbacks as optional (9a5a21f)
  • app, json-schema: admob_delay_app_measurement_init type is boolean (#5297) (d931b48), closes #5295
  • firestore: Incorrect error message for GeoPoint latitude out of range (f9909fa)
  • ios: admob shows only non-personalized ads (#5262) (0b62d5a)
  • messaging, android: avoid using rn61+ symbol (4637332), closes #5236

Features

  • analytics: Adding default event parameters (#5246) (684bb50)

... (truncated)

Commits
  • 53d9349 chore(release): release packages
  • be1bed8 feat(storage, md5hash): allow md5hash to be set on upload
  • 1d3e946 feat(storage, emulator): implement storage emulator
  • 69b6f88 chore(storage, android)!: remove EXTERNAL_STORAGE permissions for Android 10/...
  • cf7b157 test(storage, e2e): start storage emulator during testing
  • 95cdec6 test(e2e, emulator): correctly handle exit in non-ci environments
  • b73d6ff test(e2d, emulator): fix failure detection on emulator startup
  • eb8d893 fix(android): correct lint issues for various API mis-use
  • 70aba4b lint(storage, android): de-lint android storage module
  • e938824 fix(storage, android): correctly catch native exceptions for Promise.reject
  • Additional commits viewable in compare view

Updates @react-native-firebase/crashlytics from 10.5.1 to 12.0.0

Release notes

Sourced from @​react-native-firebase/crashlytics's releases.

v5.6.0 - Sign-in with Apple support, react-native 0.60+ only

Please note v5 is still seeing releases, but they are for breaking ecosystem changes only - just enough so it remains relevant for those that can't move to v6 yet.

This change allows use of Sign-in with Apple, an iOS13+ requirement to avoid rejection by the App Store if you use any forms of social authentication.

Breaking: Note that iOS13+ is only supported with Xcode 11+, which requires react-native 0.60+

You may find that react-native-firebase v5.6.x still works on react-native 0.59 (the test suite still does), but you will not be able to integrate Sign-in with Apple until you upgrade as that library is react-native 0.60+ only.

It works well with https://github.com/invertase/react-native-apple-authentication including a guide specifically for integrating with react-native-firebase, though note the import statements are for v6, you'll need to import auth in the v5 style to use it: https://github.com/invertase/react-native-apple-authentication/blob/master/docs/FIREBASE.md

See discussion in the related issue: invertase/react-native-firebase#2884

https://rnfirebase.io/docs/v5.x.x/releases/v5.6.x

Changelog

Sourced from @​react-native-firebase/crashlytics's changelog.

12.0.0 (2021-05-19)

Features

  • database: add database.useEmulator() (0632ca5)

  • sdks: firebase-ios-sdk 8.0.0 / firebase-android-sdk 28.0.1 (d97587b)

  • storage, emulator: implement storage emulator (1d3e946)

  • storage, md5hash: allow md5hash to be set on upload (be1bed8)

  • chore(storage, android)!: remove EXTERNAL_STORAGE permissions for Android 10/11 compat (69b6f88)

  • feat(firestore)!: add support for ignoreUndefinedProperties (756cfa6)

Bug Fixes

  • android: correct lint issues for various API mis-use (eb8d893), closes #3917
  • storage, android: correctly catch native exceptions for Promise.reject (e938824), closes #4097

BREAKING CHANGES

  • Storage: if you need READ_EXTERNAL_STORAGE/WRITE_EXTERNAL_STORAGE permission add them in your app AndroidManifest.xml
  • Firestore: undefined values throw like firebase-js-sdk now. Use ignoreUndefinedProperties setting 'true' to behave as before
  • AdMob: Removed from upstream SDKs. Stay on v11.5.0 for now if you need AdMob. @invertase/react-native-admob package planned with v11.5.0 code
  • ML: APIs removed from upstream SDKs. Migrate to cloud function / auth gateway to cloud APIs, as mentioned in links on ML usage document.
  • Instance ID: APIs removed from upstream SDKs. Use Messaging's getToken() to get tokens, see upstream documentation to migrate if needed
  • Messaging.getToken/deleteToken: scoped token APIs removed from upstream APIs. Remove scopes from API calls. deleteToken() should work on iOS now.

11.5.0 (2021-05-12)

Bug Fixes

  • admob: mark BannerAd callbacks as optional (9a5a21f)
  • app, json-schema: admob_delay_app_measurement_init type is boolean (#5297) (d931b48), closes #5295
  • firestore: Incorrect error message for GeoPoint latitude out of range (f9909fa)
  • ios: admob shows only non-personalized ads (#5262) (0b62d5a)
  • messaging, android: avoid using rn61+ symbol (4637332), closes #5236

Features

  • analytics: Adding default event parameters (#5246) (684bb50)

... (truncated)

Commits
  • 53d9349 chore(release): release packages
  • be1bed8 feat(storage, md5hash): allow md5hash to be set on upload
  • 1d3e946 feat(storage, emulator): implement storage emulator
  • 69b6f88 chore(storage, android)!: remove EXTERNAL_STORAGE permissions for Android 10/...
  • cf7b157 test(storage, e2e): start storage emulator during testing
  • 95cdec6 test(e2e, emulator): correctly handle exit in non-ci environments
  • b73d6ff test(e2d, emulator): fix failure detection on emulator startup
  • eb8d893 fix(android): correct lint issues for various API mis-use
  • 70aba4b lint(storage, android): de-lint android storage module
  • e938824 fix(storage, android): correctly catch native exceptions for Promise.reject
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #130 (17714d9) into master (2eeb48e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   10.94%   10.94%           
=======================================
  Files         167      167           
  Lines        6686     6686           
  Branches     1699     1699           
=======================================
  Hits          732      732           
  Misses       5954     5954           
Flag Coverage Δ
js.unittests 10.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eeb48e...17714d9. Read the comment docs.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jul 28, 2021

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Jul 28, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/js/react-native-firebase/app-and-react-native-firebase/crashlytics-12.0.0 branch July 28, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant