feat(replays): allow replay requests to query across projects #48493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JoshFerge
commented
May 3, 2023
•
JoshFerge
commented
- On the Replay Details page, since replays can be associated with backend errors and traces, we need to be able to query across projects to get the associated data associated with the replay for issues and events.
- We'll do so by adding a header to those specific requests that the backend will then look for, and allow those queries to get multi project results.
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48493 +/- ##
========================================
Coverage 80.93% 80.94%
========================================
Files 4775 4780 +5
Lines 201658 201912 +254
Branches 11503 11503
========================================
+ Hits 163221 163432 +211
- Misses 38182 38225 +43
Partials 255 255
|
markstory
reviewed
May 4, 2023
JoshFerge
commented
May 5, 2023
| "organizations:global-views", organization, actor=request.user | ||
| is_fetching_replay_data = request.headers.get("X-Sentry-Replay-Request") == "1" | ||
|
|
||
| if ( |
There was a problem hiding this comment.
are there no tests for this endpoint? 😨
eliashussary
approved these changes
May 5, 2023
eliashussary
pushed a commit
that referenced
this pull request
May 5, 2023
## Summary Adds backend error support in replay details issue tab. Requires: #48493 Relates to: #48249 Closes: #48478 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.