feat(replays): fetch replay data without projectSlug #47949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
eliashussary
commented
Apr 25, 2023
billyvg
reviewed
Apr 26, 2023
| // replays can apply to many projects when incorporating backend errors | ||
| // this makes having project in the `replaySlug` obsolete | ||
| // we must keep this url schema for now for backward compat but we should remove it at some point | ||
| // TODO: remove support for projectSlug in replay url? |
There was a problem hiding this comment.
Set a calendar invite for 90 days when current replays will be out of retention?
eliashussary
pushed a commit
that referenced
this pull request
Apr 26, 2023
## Summary Generate replay links without a projectSlug. Depends on: #47949 Note: for the sake of legibility i've created this PR to merge into [elias/replays/use-replay-data-without-project](https://github.com/getsentry/sentry/tree/elias/replays/use-replay-data-without-project)
This was referenced Apr 26, 2023
eliashussary
pushed a commit
that referenced
this pull request
Apr 26, 2023
## Summary Removes references to `replaySlug` in `deleteButton` which changes in #47949
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for fetching replay details without requiring
projectSlugin thereplaySlug. In other words we only need to passreplayId.With this change we make linking to the replay details page from backend errors and other events simpler.
Relates to: #47859
Closes: #47863