-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native stacktraces improvements #59030
Comments
Would be great if we could get ahead of this problem and find a way to pull in source snippets from GitHub |
This was always a concern when it came to GitHub's API rate limits, we have this problem in Codecove all the time 🙁 |
Routing to @getsentry/product-owners-issues for triage ⏲️ |
I still don't understand why I don't have links to GitHub in my Objective-C project... If I could write a regular expression that created accurate GitHub links based on JSON, Sentry should be able to provide them. (#43516) That said, I do really want to see the inline snippets for my Go code as well, so some solution (grabbing from GitHub or uploading code) would make the Go integration actually useful for me. |
It's only available if source context exists on the Sentry stack trace, but this is not always possible. But we still have all the required properties at hand, like filename and line number. |
@cleptric - thanks for filing this ticket! We're going to be making a series of improvements to Issue Details in Q4, and will follow up later this week if we have any questions for you. We'll update this ticket once we've figured out sequencing & timelines. cc @malwilley |
It's a bit unclear to me if anything happened related to this. Anyone has some insights?
I think it's almost never available? Why would anyone ship their source code with their binary? It's only really available if you run the application with |
@jerbob92 since this issue was created, we now will provide links to your source code for native stack traces (provided you have a source code integration and have it set up properly). Viewing source code inline, however, has not changed. It looks like there is an issue here related to making that process easier. |
@malwilley thanks, I did not find that issue myself, will start tracking that one! |
Looks like the original issue was resolved, going to close this out. Feel free to reopen if I mis interpreted the conversation. |
Not having the format of
<file>:<line>
means that I can't paste it into a VSCode Quick Open dialog or anything like that.Honestly I've said this all over the place, but it would just be really nice if I could map some file/package locations to GitHub URLs to at least link to the code. It's terribly frustrating to have literally nothing that can easily get me to the code to look at what's going wrong.
Originally posted by @eric in getsentry/sentry-go#740 (comment)
The text was updated successfully, but these errors were encountered: