Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Implementation] Frontend/UI Changes for Connecting Replay to Backend Errors #48249

Closed
6 of 7 tasks
Tracked by #45529
jas-kas opened this issue May 1, 2023 · 2 comments
Closed
6 of 7 tasks
Tracked by #45529

[Implementation] Frontend/UI Changes for Connecting Replay to Backend Errors #48249

jas-kas opened this issue May 1, 2023 · 2 comments
Assignees
@eliashussary
Labels
Product Area: Replays

Comments

@jas-kas
Copy link
Member

jas-kas commented May 1, 2023 •
edited by eliashussary
Loading

The following frontend changes required for Connecting Replay to Backend Errors per our PRD:

- Issues > Issue Details of Backend Platform that has replays associated > See replay preview/thumbnail if latest error has a replay under “Breadcrumbs”
When clicking preview, it brings you to the point of time of backend error in the replay
Also on Event Details (as found in Discover)
- (Must-have/MVP) Issues > Issue Details > All Events tab
- (Must-have/MVP) Issues > Issue Details (Backend) > Replays tab

^ Note: The last bullet above is only place where we visually distinguish frontend errors from backend errors. This is what the mocks show.

More info in this doc (Internal).

EH: adding below to epic description so i can convert to tasks and it's front and center :)
Small follow up UI/X fixes:
@jas-kas jas-kas mentioned this issue May 1, 2023
Closed
@eliashussary
Copy link
Contributor

Relates to: #45529

This was referenced May 2, 2023
Merged
Merged
eliashussary pushed a commit that referenced this issue May 3, 2023
feat(replays): query for all errors for a given replayId (#48339)
cd22801 
## Summary
This change pulls in backend errors for replay details breadcrumbs. 

Relates to: #48249
Closes: #48361
Closes: #48362
@eliashussary
Copy link
Contributor

Small follow up UI/X fixes:

  • Replay Details > Breadcrumb linking to issue tab
  • Replay Details > Filter backend errors out of console?

eliashussary pushed a commit that referenced this issue May 3, 2023
feat(replays): display error count by project (#48374)
cea61f6 
## Summary
This change adds the error count grouped by project. 
~Note this depends on: #48339 -
for legibility ive cut this PR against that branch instead of master.~

**No errs:**

![image](https://user-images.githubusercontent.com/7349258/236025424-02912ad7-9e01-46e4-abb1-bb7c21748183.png)


**1 project w/ errs:**

![image](https://user-images.githubusercontent.com/7349258/236025605-d6227063-aae6-4557-a446-db7d67ddd125.png)

**2 project w/ errs:**

![image](https://user-images.githubusercontent.com/7349258/236026985-3e317521-6829-4f76-a2d8-a91927665675.png)

**3+ project w/ errs:**

![image](https://user-images.githubusercontent.com/7349258/236025232-41c96fc7-e31a-4bf3-acb6-c68022bb3f1e.png)



Relates to: #48249
Closes: #48363
@eliashussary eliashussary self-assigned this May 3, 2023
@eliashussary eliashussary mentioned this issue May 3, 2023
Merged
eliashussary pushed a commit that referenced this issue May 5, 2023
feat(replay): details issue tab support backend errors (#48479)
7a6d28d 
## Summary 
Adds backend error support in replay details issue tab.

Requires: #48493
Relates to: #48249
Closes: #48478


![image](https://user-images.githubusercontent.com/7349258/236051551-6cf59139-0341-4da0-a461-4df610bb33af.png)
@eliashussary eliashussary mentioned this issue May 5, 2023
Merged
eliashussary pushed a commit that referenced this issue May 5, 2023
feat(replays): rm global-views check for issues#replays tab (#48641)
921f287 
## Summary
We had previously gated the issues replays tab behind the `global-views`
flag, the backend PR below allows us to override the `global-views`
restriction.

Related backend PR: #48296
Relates to: #48249
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliashussary eliashussary

Labels
Product Area: Replays
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chadwhitacre @eliashussary @jas-kas