-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design: Link error event in Replay Details (breadcrumbs) to the same error in Issues view #38461
Comments
related to #37368 |
cc: @jas-kas @ryan953
For specs, please visit the figma designs here |
@Jesse-Box I think this looks good! I notice the mocks don't have the Issues tab, will it still exist or will these changes override the need for an Issues tab? Just want to confirm. The errors link in the top-right is not as easily discoverable when compared to a tab on the page. That would be my only concern. 😄 |
So can reason for why we should keep it or remove it. We keep it, because it doesn't effect us shipping the solution I'm proposing here. We get rid of it, because people expect the issue tab to show them which error relates to which issue. I'm tending to get rid of it. @ryan953 @billyvg opinions?
I'll quickly mock this up and post an update here later. |
Go to the link below Figma design to evaluate the two concepts After exploring this idea, I came to the conclusion, that the counter in the tab makes a lot of sense for a given layout — Small Player. However, In the other layout, it gets a bit lost. If you're following my figma file, I would opt for just having "concept B", because at least it works consistently for all layout options. Below are screenshots how Firefox and Chrome show errors in the console |
I like concept b |
I also like to keep the error count in the header -> concept B I'm torn on whether to remove the Issues tab or not. It's something I'd look at after we get the errors system setup and working so we can see what it's like when both are there. |
Yeah I agree we don't need to remove it, to satisfy the requirements of this ticket. The one thing the issue tab tells me is how severe the issue actually is because of the affected users metric. |
@Jesse-Box Option B looks good to me. :) + Keeping the "Issues" tab for now |
This design ticket is closed by the implementation ticket #38861. |
Problem:
Today, there is no way to link the error event you see in Replay Details to the specific error event in Issue Details so a user can debug. The error event in Breadcrumbs does not bring you to the Issue Details at all. In addition, the Issues tab only brings you to the latest event for that Issue, not the error event from the specific session.
Solution:
TBD on Design.
The text was updated successfully, but these errors were encountered: