Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry .NET Enhanced stacktrace breaks on Mono #46

Closed
bruno-garcia opened this issue Feb 1, 2021 · 1 comment · Fixed by #1033
Closed

Sentry .NET Enhanced stacktrace breaks on Mono #46

bruno-garcia opened this issue Feb 1, 2021 · 1 comment · Fixed by #1033
Labels
Feature New feature or request Mono

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Feb 1, 2021 •
edited
Loading

Path.GetFileName throws on Mono for "<2138123765123>" values, while on .net 5 doesn't throw.

https://github.com/getsentry/sentry-dotnet/blob/4e41189a211a4b60a20180edd3bfe113dc7030e3/src/Sentry/SentryOptions.cs#L446

Work around is to use StackTraceMode.Original for now (milestone 0.1.0)

But we can change the .NET SDK to special case <mvid> and not call Path.GetFileName or any other API that breaks. In a future milestone.
@bruno-garcia bruno-garcia added this to the 0.1.0 milestone Feb 1, 2021
@semuserable semuserable self-assigned this Feb 1, 2021
@semuserable semuserable mentioned this issue Feb 5, 2021
Closed
@semuserable semuserable removed their assignment Mar 4, 2021
@semuserable
Copy link
Contributor

Should this one be removed from 0.1.0 milestone?

@bruno-garcia bruno-garcia modified the milestones: 0.1.0, 0.2.0 Apr 6, 2021
@bruno-garcia bruno-garcia added the Feature New feature or request label May 12, 2021
@bruno-garcia bruno-garcia removed this from the 0.2.0 milestone Nov 28, 2021
@bitsandfoxes bitsandfoxes moved this to Needs Discussion in Mobile & Cross Platform SDK Jan 18, 2022
@bruno-garcia bruno-garcia moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 29, 2022
@vaind vaind mentioned this issue Jul 11, 2022
Closed
@vaind vaind mentioned this issue Oct 21, 2022
Merged
Repository owner moved this from Backlog to Done in Mobile & Cross Platform SDK Oct 24, 2022
@oddgames-david oddgames-david mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request Mono
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
3 participants
@bruno-garcia @semuserable @bitsandfoxes