feat(node): Populate propagation context using env variables #8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
lforst and
Lms24
and removed request for
a team
size-limit report 📦
|
mydea
reviewed
Jun 29, 2023
packages/node/src/sdk.ts
Outdated
Comment on lines
302
to
307
| const sentryUseEnvironment = process.env.SENTRY_USE_ENVIRONMENT; | ||
| if ( | ||
| !['false', 'False', 'FALSE', 'n', 'no', 'No', 'NO', 'off', 'Off', 'OFF', '0'].includes( | ||
| sentryUseEnvironment as string, | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| const sentryUseEnvironment = process.env.SENTRY_USE_ENVIRONMENT; | |
| if ( | |
| !['false', 'False', 'FALSE', 'n', 'no', 'No', 'NO', 'off', 'Off', 'OFF', '0'].includes( | |
| sentryUseEnvironment as string, | |
| ) | |
| ) { | |
| const sentryUseEnvironment = (process.env.SENTRY_USE_ENVIRONMENT || '').toLowerCase(); | |
| if (!['false', 'n', 'no', 'off', '0'].includes(sentryUseEnvironment)) { |
l: Not a big thing, but seems easier & clearer to transform to lowercase before checking this?
mydea
approved these changes
Jun 29, 2023
Lms24
approved these changes
Jun 29, 2023
AbhiPrasad
force-pushed
the
abhi-twp-node-env
branch
from
c38d1f4 to
d6f1b11
Compare
This was referenced Jun 29, 2023
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #8421 to be merged
ref #8352
This PR adds support for https://github.com/getsentry/rfcs/blob/main/text/0071-continue-trace-over-process-boundaries.md via propagation context. When the Node SDK initializes, it grabs
process.env.SENTRY_TRACEandprocess.env.SENTRY_BAGGAGEand uses them to populate the existing propagation context.In future PRs (tracked by #8352), we will be adding support for transactions/outgoing requests to use propagation context, but for now we are only storing in propagation context, not doing anything with it.