Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Azure Functions Tracing without Performance is needed #8996

Open
thinkocapo opened this issue Sep 11, 2023 · 3 comments
Open

Node Azure Functions Tracing without Performance is needed #8996

thinkocapo opened this issue Sep 11, 2023 · 3 comments

Comments

@thinkocapo
Copy link

thinkocapo commented Sep 11, 2023

Problem Statement

Tracing is broken between frontend JS to Node Azure, 'tracing without performance'.

The js transaction on the frontend has a bunch of quesiton marks '????' to the backend.

The backend transaction does exist.

Node sdk 7.68.0
JS React sdk 7.64.0

Solution Brainstorm

should be the same traceId on both the frontend and backend events. Should not see the '????'. I'm not entirely sure what's needed to fix this.

Miscellaneous Debugging info

Comparing traceId's between the frontend and backend transactions, they're the same...if you remove the postfixed strings at the end.

frontend txn vs backend txn

"6d7d97b8f6284167b89050d56ff8a093"=="6d7d97b8f6284167b89050d56ff8a093"
true

"6d7d97b8f6284167b89050d56ff8a093"=="6d7d97b8f6284167b89050d56ff8a093-8ca96459fa381343-1"
false
@thinkocapo
Copy link
Author

@AbhiPrasad the ask is 'tracing without performance' but may I ask this be tested for 'tracing with performance' too? Maybe both techniques rely on the same code fixtures.

If 'Tracing with Performance' doesn't work either then my instinct says it will not work 'without' performance.

"measure twice, cut once"

@thinkocapo
Copy link
Author

might relate to this
#9011

@Lms24
Copy link
Member

Lms24 commented Sep 19, 2023

Adding a bit more context to this issue since I just found the slack thread:

The ask is to provide a way to pick up the incoming http request headers (sentry-trace, baggage) and to continue the trace within the wrapper in the azure function. This will be addressed by #9011.

Some extra context:

Currently, this doesn't work in Azure because unlike AWS and GCP we don't expose wrappers for the function handlers that automatically take care of continuing the trace. For Azure, we don't even recommend @sentry/serverles but @sentry/node. So IMO it totally makes sense to strive for the generic continueTrace function instead of providing an Azure specific wrapper. We could fwiw still do this afterwards and just use the continueTrace function internally but this IMO is another issue and out of scope for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants