Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$.fn.ready wrapper does not preserve properties on $ in some cases #786

Closed
kevinzang opened this issue Nov 30, 2016 · 1 comment
Closed

$.fn.ready wrapper does not preserve properties on $ in some cases #786

kevinzang opened this issue Nov 30, 2016 · 1 comment

Comments

@kevinzang
Copy link

Do you want to request a feature or report a bug?

Report a bug.

What is the current behavior?

Go to https://plnkr.co/edit/vNk2pYrM6RRN2igkrHqZ. Open Chrome console. Run the plunker. Observe error cannot read property 'bar' of undefined.

What is the expected behavior?

The console.log in the plunker should print 'baz'.

I am currently working around this by changing the self.wrap(fn) in https://github.com/getsentry/raven-js/blob/3.0.4/dist/raven.js#L1001-L1008 to self.wrap({deep: false}, fn).

Thanks in advance!
@benvinegar
Copy link
Contributor

Raven.js no longer wraps jQuery as of #849, so this issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benvinegar @kevinzang