React Navigation routing performance tracking: 'Maximum call stack size exceeded' in the /utils library

[gre]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/react

SDK Version

6.19.2

Framework Version

3.4.2 (react-native)

Link to Sentry event

https://sentry.io/share/issue/12e378b1436545c0828853d15354b7c7/

Steps to Reproduce

When using the Performance tracking in combination with React Native and the automatic instrumentation defined in https://docs.sentry.io/platforms/react-native/performance/instrumentation/automatic-instrumentation/ for the React Navigation routing, if you have "recursive objects" passed as route parameter, Sentry will badly crashes with "Maximum call stack size exceeded".

(NB: was asked to report in a new issue from #2470 (comment) )

Expected Result

Unfortunately Sentry logic isn't very protective and not preventing infinite loop in objects. an object that have nested inside some reference of a parent will infinitely make dropUndefinedKeys loop https://github.com/getsentry/sentry-javascript/blob/master/packages/utils/src/object.ts#L197

There is nothing "wrong" with the user land code actually it's crashing inside Sentry logic (at least for us) as soon as you pass a recursive object in navigation.

Not exactly sure how to fix this in the utils logic, but one policy could be to have a max depth in the recursion.

Actual Result

it badly crash the app of our users when the performance monitoring is active for them. see attached event.

[lforst]

Hi @gre, thanks for raising this issue. I saw your comment in #2470 (comment).

We are currently working on a fix for the SDK to be more defensive when being passed objects with circular references.

You can track progress in:

• fix(utils): Fix infinite recursion in dropUndefinedKeys #5163 (This one fixes the infinite recursion and is already merged - you can try version 7.0.0-rc.0 to see if this error crashes a bit less bad, however it still crashes, due to the data not being serializable)
• fix(core): Normalize trace context #5171 (This one should actually fix the problem)

The proper fix will probably be included in one of the first patches of version 7 so keep an eye out for that.

[gre]

@lforst awesome to hear. thanks

[lforst]

I'm gonna close this issue for now as we fixed this in 7.1.0. Please use 7.1.1 though as 7.1.0 was buggy.

Feel free to ping me if the problem persists on new versions!