Transaction pipeline should normalize the event.spans.data field

[marandaneto]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/browser

SDK Version

6.17.9

Framework Version

No response

Link to Sentry event

No response

Steps to Reproduce

Create a transaction and/or span.
Set non-serializable or circular reference values to the span.data and span.tags fields.
Finish the transaction.

Related issue getsentry/sentry-react-native#1477

Expected Result

Non-serializable data or circular references should be removed.
Transaction is captured.

Actual Result

The actual result depends on the broken input as data, e.g. getsentry/sentry-react-native#1477

[HazAT]

We are doing some pii, normalization tasks, closing this for now.

[marandaneto]

Unless it changed/got fixed, this is still a bug, the normalization task was not going thru the event.spans.data and tags and would cause errors, such as dropping the event altogether or causing serialization/deserialization issues on the Native layer.
The reason is that we concatenate the data from eg routers and append to the captured transaction/span in order to give more meaningful data to the user, this field isn't guaranteed to be normalized already, so instead of going and fixing every integration, it'd make more sense to actually fix in the normalization task in the JS SDK, avoiding duplication and more source for bugs.
We also did some improvements around that on the SDK a while ago, not sure if it also fixes this use case.
@krystofwoldrich would you like to double-check if this got fixed with the latest versions of the JS SDK?

[HazAT]

Thanks for the additional context, I am going to reference the RFC about PII
getsentry/rfcs#62

[krystofwoldrich]

@marandaneto Yes, I will take a look.

[krystofwoldrich]

data are normalized
tags are not
But by the typings tags can be always serializable. But It would definitely be safer to normalize them too.

[AbhiPrasad]

Going to close this as I think we've address it with v8. Please re-open if it still applies!