-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): Remove TravisCI #3149
Conversation
Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely.
size-limit report
|
@@ -10,6 +10,7 @@ jobs: | |||
job_build: | |||
name: Build | |||
runs-on: ubuntu-latest | |||
timeout-minutes: 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added timeouts to all tests as a run away job can eat up our capacity.
@@ -23,7 +23,7 @@ module.exports = { | |||
bs_android_6: { | |||
base: "BrowserStack", | |||
browser: "Android Browser", | |||
device: "Samsung Galaxy Note 4", | |||
device: "Google Nexus 6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Possible gains to be had with lerna concurrency? #3153 |
d030ccd
to
60ae3fb
Compare
Small ones, yes, but I'm not sure it'll make much of a difference, sadly. If you look at the final two commits in that PR, one with concurrency and one without, and you compare test times, you do get a small savings - around 2 min for the higher versions of node and around 1 min for the lower versions. I actually had my local repo set up to test concurrently for a while. Then I had to change it back for some reason (I forget) and I haven't gotten around to putting it back because the savings isn't that significant. In any case, unless you feel strongly, let's get this merged and worry about that separately. I was just looking at the |
Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely.