Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreTransactions and ignoreErrors #2660

Closed
3 tasks done
Tracked by #108 ...
smeubank opened this issue Apr 17, 2023 · 7 comments · Fixed by getsentry/sentry-docs#12504
Closed
3 tasks done
Tracked by #108 ...

Add ignoreTransactions and ignoreErrors #2660

smeubank opened this issue Apr 17, 2023 · 7 comments · Fixed by getsentry/sentry-docs#12504

Comments

@smeubank
Copy link
Member

smeubank commented Apr 17, 2023

Background:

To further simplfiy ignoring certain events from being sent to sentry, it is also suggested to provide ignoreTransactions and ignoreErrors

More info here develop docs updated: https://develop.sentry.dev/sdk/features/#event-sampling

  • ignoreErrors
  • ignoreTransactions
  • SDK docs
@smeubank smeubank changed the title java - Add ignoreTransactions and ignoreErrors Apr 17, 2023
@smeubank smeubank transferred this issue from getsentry/team-webplatform-meta Apr 17, 2023
@smeubank
Copy link
Member Author

@romtsn or @adinauer is it relevant to track this with another ticket for android?

@romtsn
Copy link
Member

romtsn commented Apr 17, 2023

We already have ignoreExceptionsForType, is this supposed to be ignoreErrors?

It's fine to track this for android here as well, imo.

@markushi
Copy link
Member

Keep client reports in mind: getsentry/team-webplatform-meta#46 (comment)

@stefanosiano stefanosiano moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jul 26, 2023
@stefanosiano
Copy link
Member

@smeubank Can you provide the final decision on this issue?
Also, is there a doc we can refer to?

@stefanosiano stefanosiano moved this from Backlog to Needs Discussion in Mobile & Cross Platform SDK Jul 26, 2023
@smeubank
Copy link
Member Author

We already have ignoreExceptionsForType, is this supposed to be ignoreErrors?

if this is the same as ignoreErrors in other platforms then it will suffice, would be ideal if the naming was more similar for simplicity of understanding across platforms. Seems it may behave slightly different to the other options in other SDKs though

ignoreTransactions is still needed in java and android according to docs

@markushi
Copy link
Member

markushi commented Aug 9, 2023

Java behavior: only applies to specific class type, but not child classes. - as opposed to .net and Dart.

@markushi
Copy link
Member

markushi commented Aug 9, 2023

Let's just focus on adding ignoreTransactions within this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants