From fb6f00516d5b96ad8a10562103c8f9ae44d75d0d Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Tue, 27 Aug 2024 07:24:40 +0200 Subject: [PATCH] Use RECORD_ONLY sampling decision if performance is disabled --- .../main/java/io/sentry/opentelemetry/SentrySampler.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java b/sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java index eaed924bfa8..6729589744f 100644 --- a/sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java +++ b/sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java @@ -70,9 +70,9 @@ public SamplingResult shouldSample( private @NotNull SamplingResult handleRootOtelSpan( final @NotNull String traceId, final @NotNull Context parentContext) { - if (!scopes.getOptions().isTraceSampling()) { - // TODO [POTEL] should this return RECORD_ONLY to allow tracing without performance - return SamplingResult.create(SamplingDecision.DROP); + if (!scopes.getOptions().isTracingEnabled()) { + System.out.println("not trace sampling -> RECORD_ONLY " + traceId); + return SamplingResult.create(SamplingDecision.RECORD_ONLY); } @Nullable Baggage baggage = null; @Nullable