Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rn): Add Tracing without Performance docs #7602

Merged
merged 6 commits into from
Aug 11, 2023
Merged

feat(rn): Add Tracing without Performance docs #7602

merged 6 commits into from
Aug 11, 2023

Conversation

krystofwoldrich
Copy link
Member

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Aug 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 3:14pm

@krystofwoldrich krystofwoldrich mentioned this pull request Aug 8, 2023
Merged
9 tasks
@krystofwoldrich krystofwoldrich merged commit 3d8afcb into master Aug 11, 2023
@krystofwoldrich krystofwoldrich deleted the kw-rn-twp branch August 11, 2023 09:14
liamjones
liamjones reviewed Aug 11, 2023
View reviewed changes
src/platform-includes/distributed-tracing/how-to-use/react-native.mdx
});
```

If you're using version `5.9.x` or below, you'll need to have our <PlatformLink to="/performance/">performance monitoring feature enabled</PlatformLink> in order for distributed tracing to work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 5.8.x or below? The release notes for sentry-react-native 5.9.0 say you don't need perf monitoring

@liamjones
Copy link
Contributor

@krystofwoldrich Could I query something extra in relation to this docs update too?

We now have tracePropagationTargets at the top-level config of Sentry.init() but it looks like it still exists in the options of the Sentry.ReactNativeTracing constructor too: https://docs.sentry.io/platforms/react-native/performance/instrumentation/automatic-instrumentation/#tracepropagationtargets

How do the two interact (or not)? E.g. if it's specified at the root can it be skipped from the tracing constructor options and it'll be inherited? Does it need to be set in both places? If specified in both places would the tracing one override the top-level one?

@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamjones liamjones liamjones left review comments

@marandaneto marandaneto marandaneto left review comments

@shanamatthews shanamatthews shanamatthews approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lizokm lizokm Awaiting requested review from lizokm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krystofwoldrich @liamjones @shanamatthews @marandaneto @AbhiPrasad