diff --git a/flutter/example/integration_test/web_sdk_test.dart b/flutter/example/integration_test/web_sdk_test.dart index 006a52e80..48ecc2044 100644 --- a/flutter/example/integration_test/web_sdk_test.dart +++ b/flutter/example/integration_test/web_sdk_test.dart @@ -107,11 +107,10 @@ void main() { expect((header['sdk'] as Map)['name'], 'sentry.dart.flutter'); - final item = (envelope[1] as List).first as List; - final itemPayloadJs = (item[1] as JSArray).toDart; - final itemPayload = json.decode(utf8.decoder.convert(itemPayloadJs - .map((el) => int.parse(el.dartify().toString())) - .toList())) as Map; + final item = (envelope[1] as List).first as List; + final itemPayload = + json.decode(utf8.decoder.convert(item[1] as List)) + as Map; final jsEventJson = (itemPayload).map((key, value) { return MapEntry(key.toString(), value as dynamic); diff --git a/flutter/test/web/sentry_web_test.dart b/flutter/test/web/sentry_web_test.dart index 2595d781b..6a85dfe62 100644 --- a/flutter/test/web/sentry_web_test.dart +++ b/flutter/test/web/sentry_web_test.dart @@ -42,47 +42,46 @@ void main() { await sut.close(); }); - // TODO: re-enable this test in V9 - // test('init: options mapped to JS SDK', () async { - // const expectedDsn = 'https://random@def.ingest.sentry.io/1234567'; - // const expectedRelease = 'my-random-release'; - // const expectedSampleRate = 0.2; - // const expectedEnv = 'my-random-env'; - // const expectedDist = '999'; - // const expectedAttachStacktrace = false; - // const expectedMaxBreadcrumbs = 1000; - // const expectedDebug = true; - // - // options.dsn = expectedDsn; - // options.release = expectedRelease; - // options.sampleRate = expectedSampleRate; - // options.environment = expectedEnv; - // options.dist = expectedDist; - // options.attachStacktrace = expectedAttachStacktrace; - // options.maxBreadcrumbs = expectedMaxBreadcrumbs; - // options.debug = expectedDebug; - // - // // quick check that Sentry is not initialized first - // expect(() => binding.getJsOptions()['dsn'], throwsA(anything)); - // - // await sut.init(hub); - // - // final jsOptions = binding.getJsOptions(); - // - // expect(jsOptions['dsn'], expectedDsn); - // expect(jsOptions['release'], expectedRelease); - // expect(jsOptions['sampleRate'], expectedSampleRate); - // expect(jsOptions['environment'], expectedEnv); - // expect(jsOptions['dist'], expectedDist); - // expect(jsOptions['attachStacktrace'], expectedAttachStacktrace); - // expect(jsOptions['maxBreadcrumbs'], expectedMaxBreadcrumbs); - // expect(jsOptions['debug'], expectedDebug); - // expect(jsOptions['defaultIntegrations'].length, 2); - // expect(jsOptions['defaultIntegrations'][0].toString(), - // contains('name: GlobalHandlers')); - // expect(jsOptions['defaultIntegrations'][1].toString(), - // contains('name: Dedupe')); - // }); + test('init: options mapped to JS SDK', () async { + const expectedDsn = 'https://random@def.ingest.sentry.io/1234567'; + const expectedRelease = 'my-random-release'; + const expectedSampleRate = 0.2; + const expectedEnv = 'my-random-env'; + const expectedDist = '999'; + const expectedAttachStacktrace = false; + const expectedMaxBreadcrumbs = 1000; + const expectedDebug = true; + + options.dsn = expectedDsn; + options.release = expectedRelease; + options.sampleRate = expectedSampleRate; + options.environment = expectedEnv; + options.dist = expectedDist; + options.attachStacktrace = expectedAttachStacktrace; + options.maxBreadcrumbs = expectedMaxBreadcrumbs; + options.debug = expectedDebug; + + // quick check that Sentry is not initialized first + expect(() => binding.getJsOptions()['dsn'], throwsA(anything)); + + await sut.init(hub); + + final jsOptions = binding.getJsOptions(); + + expect(jsOptions['dsn'], expectedDsn); + expect(jsOptions['release'], expectedRelease); + expect(jsOptions['sampleRate'], expectedSampleRate); + expect(jsOptions['environment'], expectedEnv); + expect(jsOptions['dist'], expectedDist); + expect(jsOptions['attachStacktrace'], expectedAttachStacktrace); + expect(jsOptions['maxBreadcrumbs'], expectedMaxBreadcrumbs); + expect(jsOptions['debug'], expectedDebug); + expect(jsOptions['defaultIntegrations'].length, 2); + expect(jsOptions['defaultIntegrations'][0].toString(), + contains('name: GlobalHandlers')); + expect(jsOptions['defaultIntegrations'][1].toString(), + contains('name: Dedupe')); + }); test('options getter returns the original options', () { expect(sut.options, same(options));