From b3bb4f17aeabd3e78f57df3c8139d02006f40989 Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Wed, 22 Jan 2025 17:39:20 +0100 Subject: [PATCH 1/3] Update tests for new `options.debug` behaviour --- dart/test/sentry_test.dart | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dart/test/sentry_test.dart b/dart/test/sentry_test.dart index ab510095bd..56f2cf8cca 100644 --- a/dart/test/sentry_test.dart +++ b/dart/test/sentry_test.dart @@ -440,7 +440,7 @@ void main() { (options) { options.dsn = fakeDsn; expect(options.environment, 'debug'); - expect(options.debug, false); + expect(options.debug, true); }, options: sentryOptions, ); @@ -500,7 +500,8 @@ void main() { }); test('throw is handled and logged', () async { - final sentryOptions = defaultTestOptions() + // Use release mode in platform checker to avoid additional log + final sentryOptions = defaultTestOptions(FakePlatformChecker.releaseMode()) ..automatedTestMode = false ..debug = true ..logger = fixture.mockLogger; From 488700c0613d913140ad630596d045492295bab0 Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Wed, 22 Jan 2025 18:19:42 +0100 Subject: [PATCH 2/3] fix test expectation in sentry_flutter_test --- flutter/test/sentry_flutter_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flutter/test/sentry_flutter_test.dart b/flutter/test/sentry_flutter_test.dart index d69d2fd701..d6fd3d97b4 100644 --- a/flutter/test/sentry_flutter_test.dart +++ b/flutter/test/sentry_flutter_test.dart @@ -622,7 +622,7 @@ void main() { await SentryFlutter.init( (options) { - expect(false, options.debug); + expect(true, options.debug); expect('debug', options.environment); expect(sdkName, options.sdk.name); expect(sdkVersion, options.sdk.version); From 1005d6b34ca9ecd53ebe9a1dcdcf03fc581262e8 Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Wed, 22 Jan 2025 19:14:55 +0100 Subject: [PATCH 3/3] analyze --- dart/test/sentry_test.dart | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dart/test/sentry_test.dart b/dart/test/sentry_test.dart index 56f2cf8cca..0ebae3b726 100644 --- a/dart/test/sentry_test.dart +++ b/dart/test/sentry_test.dart @@ -501,10 +501,11 @@ void main() { test('throw is handled and logged', () async { // Use release mode in platform checker to avoid additional log - final sentryOptions = defaultTestOptions(FakePlatformChecker.releaseMode()) - ..automatedTestMode = false - ..debug = true - ..logger = fixture.mockLogger; + final sentryOptions = + defaultTestOptions(FakePlatformChecker.releaseMode()) + ..automatedTestMode = false + ..debug = true + ..logger = fixture.mockLogger; final exception = Exception("Exception in options callback"); await Sentry.init(