Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for new options.debug behaviour #2609

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jan 22, 2025

#skip-changelog

📜 Description

Update tests for new options.debug behaviour

💡 Motivation and Context

Fixes test expectations that changed when new options.debug was introduced.

@denrase denrase marked this pull request as ready for review January 22, 2025 16:40
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (4f6634c) to head (1005d6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2609       +/-   ##
===========================================
+ Coverage   78.37%   89.10%   +10.73%     
===========================================
  Files          35      263      +228     
  Lines        1489     8943     +7454     
===========================================
+ Hits         1167     7969     +6802     
- Misses        322      974      +652     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1249.73 ms 1268.94 ms 19.20 ms
Size 8.42 MiB 9.91 MiB 1.49 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8e133ad 1268.19 ms 1277.37 ms 9.18 ms
9d43f71 1225.06 ms 1227.06 ms 2.00 ms
aed5947 1268.67 ms 1281.10 ms 12.43 ms
a43c400 1242.04 ms 1262.98 ms 20.94 ms
6325c3b 1266.52 ms 1291.06 ms 24.54 ms
f275487 1291.65 ms 1339.92 ms 48.26 ms
a7acb24 1296.71 ms 1317.69 ms 20.98 ms
464b4d0 1249.02 ms 1261.22 ms 12.20 ms
72dfc83 1262.50 ms 1289.75 ms 27.25 ms
9fe67d5 1242.33 ms 1268.77 ms 26.44 ms

App size

Revision Plain With Sentry Diff
8e133ad 8.10 MiB 9.16 MiB 1.07 MiB
9d43f71 8.29 MiB 9.39 MiB 1.10 MiB
aed5947 8.16 MiB 9.17 MiB 1.01 MiB
a43c400 8.42 MiB 9.89 MiB 1.46 MiB
6325c3b 8.16 MiB 9.17 MiB 1.01 MiB
f275487 8.32 MiB 9.38 MiB 1.05 MiB
a7acb24 8.16 MiB 9.17 MiB 1.01 MiB
464b4d0 8.10 MiB 9.16 MiB 1.07 MiB
72dfc83 8.15 MiB 9.12 MiB 987.30 KiB
9fe67d5 8.32 MiB 9.50 MiB 1.18 MiB

Previous results on branch: fix/options-debug-tests

Startup times

Revision Plain With Sentry Diff
488700c 1250.14 ms 1265.88 ms 15.73 ms

App size

Revision Plain With Sentry Diff
488700c 8.42 MiB 9.91 MiB 1.49 MiB

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 435.98 ms 531.61 ms 95.63 ms
Size 6.46 MiB 7.48 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d4120ac 373.14 ms 447.35 ms 74.21 ms
4c78360 402.29 ms 462.04 ms 59.76 ms
117d988 376.32 ms 450.85 ms 74.53 ms
62dde43 339.21 ms 423.06 ms 83.85 ms
a49594a 282.27 ms 344.84 ms 62.57 ms
e964e2b 365.15 ms 431.00 ms 65.85 ms
6f3717a 359.20 ms 422.88 ms 63.67 ms
a80fbd1 461.14 ms 496.84 ms 35.70 ms
d5f600b 392.88 ms 466.73 ms 73.85 ms
b728df4 390.98 ms 445.81 ms 54.83 ms

App size

Revision Plain With Sentry Diff
d4120ac 6.27 MiB 7.20 MiB 960.42 KiB
4c78360 6.33 MiB 7.27 MiB 954.08 KiB
117d988 6.33 MiB 7.26 MiB 947.03 KiB
62dde43 5.94 MiB 6.96 MiB 1.02 MiB
a49594a 5.94 MiB 6.95 MiB 1.01 MiB
e964e2b 6.33 MiB 7.28 MiB 962.81 KiB
6f3717a 6.35 MiB 7.35 MiB 1017.82 KiB
a80fbd1 6.46 MiB 7.48 MiB 1.02 MiB
d5f600b 6.33 MiB 7.26 MiB 943.41 KiB
b728df4 5.94 MiB 6.95 MiB 1.01 MiB

Previous results on branch: fix/options-debug-tests

Startup times

Revision Plain With Sentry Diff
488700c 442.54 ms 495.06 ms 52.52 ms

App size

Revision Plain With Sentry Diff
488700c 6.46 MiB 7.48 MiB 1.02 MiB

@buenaflor
Copy link
Contributor

@denrase one analyze fail and the others are I think flakes

@denrase denrase enabled auto-merge (squash) January 23, 2025 09:32
@denrase
Copy link
Collaborator Author

denrase commented Jan 23, 2025

@buenaflor Thx for the fix! Now just SDK metrics fails.

@buenaflor
Copy link
Contributor

they're usually flaky, I reran them

@denrase
Copy link
Collaborator Author

denrase commented Jan 23, 2025

@buenaflor All passed, only approval missing :)

@denrase denrase merged commit 25fdf12 into main Jan 23, 2025
161 checks passed
@denrase denrase deleted the fix/options-debug-tests branch January 23, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants